[Docs] Replace markdownlint with mdformat and configure myst-parser #493
Conversation
RunningLeon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
- Coverage 57.38% 57.14% -0.24%
==========================================
Files 259 259
Lines 8574 8574
Branches 1281 1281
==========================================
- Hits 4920 4900 -20
- Misses 3301 3322 +21
+ Partials 353 352 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Let's deal with it when dev-0.5.0 is ready. Otherwise, lots of conflicts will drive us mad |
This reverts commit 101108f.
| 'fcos_r50_caffe_fpn_gn-head_1x_coco.py') | ||
| >>> model_checkpoint = ('checkpoints/' | ||
| 'fcos_r50_caffe_fpn_gn-head_1x_coco-821213aa.pth') | ||
| >>> deploy_cfg = 'configs/mmdet/detection/' \ |
There was a problem hiding this comment.
Is this line broken by pre-commit automatically? '\' makes API docs not pretty in readthedocs. We used to fix it in PR #495
| @@ -154,7 +154,7 @@ def impl(ys, prefix, level): | |||
| if ys not in visit: | |||
| visit.add(ys) | |||
| root = ctx.names[ctx.index] | |||
| name = '.'.join(str(x) for x in (root, *prefix)) | |||
| name = '/'.join(str(x) for x in (root, *prefix)) | |||
There was a problem hiding this comment.
I think it has been fixed in another PR. May rebase master
There was a problem hiding this comment.
Yes. Before there are a lot of conflicts. To make it clean, I reverted some commits. Maybe something wrong when revert the merge commit. rebase to master not work in this case.
| @@ -201,7 +201,7 @@ def multiclass_nms__default(ctx, | |||
| """ | |||
| deploy_cfg = ctx.cfg | |||
| batch_size = boxes.size(0) | |||
| if not is_dynamic_batch(deploy_cfg) and batch_size == 1: | |||
| if not is_dynamic_batch(deploy_cfg) and batch_size != 1: | |||
There was a problem hiding this comment.
I think it has been fixed in another PR. May rebase master
| | ONNX Runtime | TensorRT | ppl.nn | ncnn | OpenVINO | more | | ||
| | ------------ | -------- | ------ | ---- | -------- | ------------------------------------------------- | | ||
| | ✔️ | ✔️ | ✔️ | ✔️ | ✔️ | [benchmark](docs/zh_cn/03-benchmark/benchmark.md) | | ||
| | ✔️ | ✔️ | ✔️ | ✔️ | ✔️ | [benchmark](docs/zh_cn/03-benchmark/benchmark.md) | |
There was a problem hiding this comment.
Hi, @zhouzaida mdformat adjusts this table by mistake.
| 'fcos_r50_caffe_fpn_gn-head_1x_coco.py') | ||
| >>> deploy_cfg = ('configs/mmdet/detection/' | ||
| 'detection_onnxruntime_dynamic.py') | ||
| >>> model_cfg = 'mmdetection/configs/fcos/' \ |
There was a problem hiding this comment.
Is this line broken by pre-commit automatically? '' makes API docs not pretty in readthedocs. We used to fix it in PR #495
There was a problem hiding this comment.
I'll update it. maybe there's a mistake when revert merge commit.
|
How about we drop this PR and apply "markdownlint: open-mmlab/mmcv#1936" and "open-mmlab/mmocr#1012" to the latest mmdeploy directly? |
OK |
|
move to #610 |
Motivation
Following:
Replace markdownlint: open-mmlab/mmcv#1936
Configure Myst-parser to parse anchor tag: open-mmlab/mmocr#1012
Modification
md docs
BC-breaking (Optional)
None