[Enhancement] Adjust csrc structure
#594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
=======================================
Coverage 57.42% 57.42%
=======================================
Files 258 258
Lines 8561 8561
Branches 1279 1279
=======================================
Hits 4916 4916
Misses 3292 3292
Partials 353 353
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
#include "pose_detector.h" // include "mmdeploy/c/pose_detector.h" |
lvhan028
reviewed
Jun 13, 2022
csrc/mmdeploy/apis/c/CMakeLists.txt
Outdated
| endforeach () | ||
|
|
||
| install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/common.h | ||
| DESTINATION include/c) | ||
| #install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/common.h |
There was a problem hiding this comment.
May remove the useless code
Comment on lines
5
to
+8
| #include "common.h" | ||
| #include "common_internal.h" | ||
| #include "execution/when_all_value.h" | ||
| #include "executor_internal.h" | ||
| #include "mmdeploy/execution/when_all_value.h" |
There was a problem hiding this comment.
Can we include the header file in the same pattern, e.g., the relative path to ${MMDEPLOY_ROOT_DIR}/csrc ?
irexyc
approved these changes
Jun 13, 2022
lvhan028
approved these changes
Jun 14, 2022
This was referenced Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.