add act_cfg #2239
Merged
add act_cfg #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellock
reviewed
Mar 11, 2020
hellock
reviewed
Mar 12, 2020
| @@ -41,7 +41,7 @@ def __init__(self, | |||
| out_channels, | |||
| kernel_size=1, | |||
| bias=False, | |||
| activation=None, | |||
| act_cfg=None, | |||
| conv_cfg=conv_cfg, | |||
| norm_cfg=norm_cfg) | |||
There was a problem hiding this comment.
We may follow the argument order: conv_cfg, norm_cfg, act_cfg.
mmdet/models/utils/conv_module.py
Outdated
| @@ -60,7 +61,7 @@ class ConvModule(nn.Module): | |||
| False. | |||
| conv_cfg (dict): Config dict for convolution layer. | |||
| norm_cfg (dict): Config dict for normalization layer. | |||
| activation (str or None): Activation type, "ReLU" by default. | |||
| act_cfg (str or None): Activation type, "ReLU" by default. | |||
hellock
reviewed
Mar 12, 2020
mmdet/models/utils/activation.py
Outdated
| import torch.nn as nn | ||
|
|
||
| activation_cfg = { | ||
| # format: layer_type: (abbreviation, module) |
hellock
approved these changes
Mar 12, 2020
ioir123ju
pushed a commit
to ioir123ju/mmdetection
that referenced
this pull request
Mar 30, 2020
* add act_cfg * add more act_cfg options * delel GELU * reorder args, save act_cfg, update doc * update doc
mike112223
pushed a commit
to mike112223/mmdetection
that referenced
this pull request
Aug 25, 2020
* add act_cfg * add more act_cfg options * delel GELU * reorder args, save act_cfg, update doc * update doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This added config for activation so that user could use activation like
reluandleaky_relu.