Fixed bugs about cascade_roi_head. #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed the bug of refining bg rois at training when reg_class_agnostic is False. * Fixed the bug of potentially infering roi label to be bg at inference.
|
Hi @Jokoe66 , |
|
Hi, I don't validate it yet due to gpu limit.
Besides, I think the training logic of class-aware cascade roi head needs further modification. Under current modification, class-aware cascade roi head does not refine negative rois at training, but do it at inference by regarding them as their closest objects. I think it's better to keep the behavior at training consistent with that at inference. So I will change the labels of bg rois used to refine rois at training to what will be at inference.
|
Jokoe66
commented
Jul 9, 2020
|
The code looks good to me now. I will benchmark some models to validate the modification. |
Sure. Thanks. |
|
The performance seems OK. I ran cascade mask r50 three times and obtained 41.1/35.9, 41.2/35.9, and 41.1/35.8 box/mask mAP. |
ZwwWayne
approved these changes
Jul 21, 2020
mike112223
pushed a commit
to mike112223/mmdetection
that referenced
this pull request
Aug 25, 2020
* Fixed bugs about cascade_roi_head. * Fixed the bug of refining bg rois at training when reg_class_agnostic is False. * Fixed the bug of potentially infering roi label to be bg at inference. * Reformatted code. * Ensured foreground roi_labels when refining bboxes at training. * Fixed typo. * Fixed incompatibility between mmdet2.2(ops/conv_ws.py) and mmcv1.0.0 * Fixed typo.
FANGAreNotGnu
pushed a commit
to FANGAreNotGnu/mmdetection
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug of refining bg rois at training when reg_class_agnostic is False.
Fixed the bug of potentially infering roi label to be bg at inference.