Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize runner type #4570

Merged
merged 9 commits into from
Feb 18, 2021
Merged

Customize runner type #4570

merged 9 commits into from
Feb 18, 2021

Conversation

yhcao6
Copy link
Collaborator

@yhcao6 yhcao6 commented Feb 3, 2021

Add support to customize runner type ('EpochBasedRunner', 'IterBasedRunner') and merge the 'total_epoch' attribute in the config with the newly added runner attribute as follows:

runner = dict(type='EpochBasedRunner', max_epochs=12)

@yhcao6 yhcao6 requested a review from ZwwWayne February 3, 2021 04:42
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #4570 (cacb1de) into master (c2afc5a) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4570      +/-   ##
==========================================
- Coverage   64.31%   64.29%   -0.02%     
==========================================
  Files         250      250              
  Lines       19249    19286      +37     
  Branches     3252     3264      +12     
==========================================
+ Hits        12380    12400      +20     
- Misses       6223     6234      +11     
- Partials      646      652       +6     
Flag Coverage Δ
unittests 64.25% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/dense_heads/gfl_head.py 27.35% <0.00%> (ø)
mmdet/apis/train.py 16.21% <9.09%> (-0.46%) ⬇️
mmdet/datasets/pipelines/transforms.py 72.60% <33.33%> (-0.31%) ⬇️
mmdet/core/evaluation/eval_hooks.py 51.70% <40.47%> (-3.14%) ⬇️
mmdet/models/dense_heads/corner_head.py 76.35% <0.00%> (+1.90%) ⬆️
mmdet/models/detectors/cornernet.py 100.00% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2afc5a...933300a. Read the comment docs.

@ZwwWayne
Copy link
Collaborator

LGTM after resolving comments. Please @jshilong also have a look.

mmdet/apis/train.py Outdated Show resolved Hide resolved
mmdet/apis/train.py Show resolved Hide resolved
mmdet/core/evaluation/eval_hooks.py Outdated Show resolved Hide resolved
mmdet/core/evaluation/eval_hooks.py Outdated Show resolved Hide resolved
mmdet/core/evaluation/eval_hooks.py Outdated Show resolved Hide resolved
mmdet/core/evaluation/eval_hooks.py Outdated Show resolved Hide resolved
docs/tutorials/config.md Outdated Show resolved Hide resolved
@ZwwWayne
Copy link
Collaborator

May also enrich the PR message to describe the supported feature and migration code in detail. Thus other users could understand the PR more clearly as this modification is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants