Feature Pyramid Grids #4645
Merged
Feature Pyramid Grids #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4645 +/- ##
==========================================
- Coverage 64.17% 64.03% -0.14%
==========================================
Files 250 252 +2
Lines 19286 19631 +345
Branches 3264 3323 +59
==========================================
+ Hits 12377 12571 +194
- Misses 6258 6393 +135
- Partials 651 667 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ZwwWayne
approved these changes
Feb 21, 2021
ZwwWayne
reviewed
Feb 25, 2021
| norm_cfg (dict): Config dict for normalization layer. Default: None. | ||
| """ | ||
|
|
||
| transition_types = { |
There was a problem hiding this comment.
Can we create a new registry for transition thus we could extend the transitions without modifying the code in fpg.py?
ZwwWayne
reviewed
Feb 25, 2021
| self.out_channels = out_channels | ||
| self.num_ins = len(in_channels) | ||
| self.num_outs = num_outs | ||
| if inter_channels is None: |
There was a problem hiding this comment.
Do we need a unit test to more comprehensively test this module?
hellock
reviewed
Feb 25, 2021
ZwwWayne
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of FPG that published in https://arxiv.org/abs/2004.03580.
Here is the mAP comparison of this PR and paper: