Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RPN show_result error #4716

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Conversation

hhaAndroid
Copy link
Collaborator

Fix RPN show_result error

@hhaAndroid hhaAndroid requested review from jshilong and ZwwWayne March 5, 2021 03:53
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #4716 (a3f5a15) into master (9946e12) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4716      +/-   ##
==========================================
- Coverage   63.89%   63.84%   -0.05%     
==========================================
  Files         252      252              
  Lines       19658    19583      -75     
  Branches     3329     3341      +12     
==========================================
- Hits        12560    12503      -57     
+ Misses       6426     6400      -26     
- Partials      672      680       +8     
Flag Coverage Δ
unittests 63.81% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/dense_heads/embedding_rpn_head.py 97.29% <ø> (+17.70%) ⬆️
mmdet/models/detectors/cascade_rcnn.py 50.00% <ø> (ø)
mmdet/models/detectors/rpn.py 67.24% <50.00%> (+7.24%) ⬆️
mmdet/core/bbox/coder/base_bbox_coder.py 75.00% <0.00%> (-5.00%) ⬇️
mmdet/models/detectors/single_stage.py 80.35% <0.00%> (-4.55%) ⬇️
mmdet/models/roi_heads/base_roi_head.py 76.31% <0.00%> (-3.69%) ⬇️
mmdet/models/dense_heads/rpn_head.py 69.47% <0.00%> (-3.57%) ⬇️
mmdet/models/detectors/two_stage.py 71.26% <0.00%> (-3.16%) ⬇️
mmdet/models/detectors/base.py 52.80% <0.00%> (-2.51%) ⬇️
mmdet/core/bbox/coder/yolo_bbox_coder.py 58.97% <0.00%> (-2.01%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9946e12...a3f5a15. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 895a8d5 into open-mmlab:master Mar 12, 2021
@hhaAndroid hhaAndroid deleted the fix_rpn_show_result branch March 15, 2021 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants