-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Add simple_test to dense heads #5061
Closed
Closed
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7578b6c
[Refactor] Add simple_test to dense heads
shinya7y 5d9138d
Move test methods of RPN
shinya7y af9cdbc
Fix assert
shinya7y ebdff63
Merge remote-tracking branch 'upstream/master'
shinya7y 81e62cd
Merge remote-tracking branch 'upstream/master'
shinya7y a185bbf
move fun and add docstr
hhaAndroid d396dc3
Move parameter position
hhaAndroid f4a2021
Conflict resolution and merge master branch
hhaAndroid 23b5ff3
add yolact docstr
hhaAndroid 0e6c6cc
(1) Provide more detailed error information; (2) fix centernet aug er…
hhaAndroid 69a4ed7
Merge branch 'master' of https://github.com/open-mmlab/mmdetection in…
hhaAndroid 2e635eb
Supports for exporting CornerNet to ONNX with dynamic shapes and comp…
v-qjqs 52c935d
Fix torch.chunk int32 overflow (#5191)
ypwhs 8d40aef
[Feature]: Evaluation with TensorRT backend (#5198)
RunningLeon a8c681d
Bump version to v2.13.0 (#5262)
jshilong 90656ee
resolve conflict and move bbbox2results to one_stage
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems you add this arguments
postprocess
to get raw results of boxes inyolact
, but I believe original design keepbbbox2results
is single-stage would a better design and can do the same thing, Is there other reasons?In addition, I think keeping this operation in the
SingleStageDetector
instead ofsimple_test_bboxes
would be more consistent with the two-tage models.just like
mmdetection/mmdet/models/roi_heads/standard_roi_head.py
Line 233 in 24b6f93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the argument
postprocess
to simplify code for onnx.mmdetection/mmdet/models/detectors/single_stage.py
Lines 117 to 118 in 7578b6c
The original reason disappeared after #5205
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall design looks good to me, and I would help to move
bbbox2results
tosimple_test
of single_stage.py.It would be merged soon, Thanks for your contribution.