Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update get_indexes in mixup #6516

Closed
wants to merge 1 commit into from
Closed

update get_indexes in mixup #6516

wants to merge 1 commit into from

Conversation

zhaoxin111
Copy link
Contributor

Motivation

When the parameter dataset in MultiImageMixDataset is ConcatDataset/RepeatDataset/ClassBalancedDataset and mixup is added in the pipeline, the get_indexes in mixup will crash since there are no get_ann_info in ConcatDataset/RepeatDataset/ClassBalancedDataset.

Modification

change gt_bboxes_i = dataset.get_ann_info(index)['bboxes']
to gt_bboxes_i = dataset[index]['gt_bboxes']

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hhaAndroid
Copy link
Collaborator

@zhaoxin111 Thanks for your contribution! At that time, I didn't want to read the IMG every time in the loop when designing, because it didn't need it. I think the PR you mentioned is more reasonable. Our plan is to merge this PR.

@zhaoxin111
Copy link
Contributor Author

zhaoxin111 commented Nov 16, 2021

@zhaoxin111 Thanks for your contribution! At that time, I didn't want to read the IMG every time in the loop when designing, because it didn't need it. I think the PR you mentioned is more reasonable. Our plan is to merge this PR.

OK, I will reopen th PR and fix it.

@ZwwWayne
Copy link
Collaborator

Closed as it is continued in #6526

@ZwwWayne ZwwWayne closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants