[Fix] Fix Open Images testunit to avoid error in Windows CI

mmdet/datasets/openimages.py

@@ -262,10 +262,10 @@ def get_meta_from_file(self, meta_file=''):
         metas = mmcv.load(meta_file)
         assert len(metas) == len(self)
         for i in range(len(metas)):
-            file_name = metas[i]['filename'].split('/')[-1]
+            file_name = osp.split(metas[i]['filename'])[-1]
             img_info = self.data_infos[i].get('img_info', None)
             if img_info is not None:
-                assert file_name == img_info['filename'].split('/')[-1]
+                assert file_name == osp.split(img_info['filename'])[-1]
             else:
                 assert file_name == self.data_infos[i]['filename']
             hw = metas[i]['ori_shape'][:2]
@@ -286,10 +286,10 @@ def get_img_shape(self, metas):
         """Set images original shape into data_infos."""
         assert len(metas) == len(self)
         for i in range(len(metas)):
-            file_name = metas[i].data['filename'].split('/')[-1]
+            file_name = osp.split(metas[i].data['ori_filename'])[-1]
             img_info = self.data_infos[i].get('img_info', None)
             if img_info is not None:
-                assert file_name == img_info['filename'].split('/')[-1]
+                assert file_name == osp.split(img_info['filename'])[-1]
             else:
                 assert file_name == self.data_infos[i]['filename']
             hw = metas[i].data['ori_shape'][:2]
@@ -519,7 +519,7 @@ def get_image_level_ann(self, image_level_ann_file):
             img_info = self.data_infos[i].get('img_info', None)
             if img_info is not None:
                 # for Open Images Challenges
-                img_id = img_info['filename'].split('/')[-1][:-4]
+                img_id = osp.split(img_info['filename'])[-1][:-4]
             else:
                 # for Open Images v6
                 img_id = self.data_infos[i]['img_id']

tests/test_data/test_datasets/test_openimages_dataset.py

@@ -14,7 +14,7 @@ def _create_ids_error_oid_csv(
     fake_csv_file,
 ):
     label_description = ['/m/000002', 'Football']
-    with open(label_file, 'w') as f:
+    with open(label_file, 'w', newline='') as f:
         f_csv = csv.writer(f)
         f_csv.writerow(label_description)
 
@@ -31,7 +31,9 @@ def _create_ids_error_oid_csv(
                        '000595fe6fee6369', 'xclick', '/m/000000', '1', '0',
                        '1', '0', '1', '0', '0', '1', '0', '0'
                    ]]
-    with open(fake_csv_file, 'w') as f:
+    # `newline=''` is used to avoid index error of out of bounds
+    # in Windows system
+    with open(fake_csv_file, 'w', newline='') as f:
         f_csv = csv.writer(f)
         f_csv.writerow(header)
         f_csv.writerows(annotations)
@@ -41,7 +43,7 @@ def _create_oid_style_ann(label_file, csv_file, label_level_file):
     label_description = [['/m/000000', 'Sports equipment'],
                          ['/m/000001', 'Ball'], ['/m/000002', 'Football'],
                          ['/m/000004', 'Bicycle']]
-    with open(label_file, 'w') as f:
+    with open(label_file, 'w', newline='') as f:
         f_csv = csv.writer(f)
         f_csv.writerows(label_description)
 
@@ -60,15 +62,19 @@ def _create_oid_style_ann(label_file, csv_file, label_level_file):
             0, 0, 0, 0
         ],
     ]
-    with open(csv_file, 'w') as f:
+    # `newline=''` is used to avoid index error of out of bounds
+    # in Windows system
+    with open(csv_file, 'w', newline='') as f:
         f_csv = csv.writer(f)
         f_csv.writerow(header)
         f_csv.writerows(annotations)
 
     header = ['ImageID', 'Source', 'LabelName', 'Confidence']
     annotations = [['color', 'xclick', '/m/000002', '1'],
                    ['color', 'xclick', '/m/000004', '0']]
-    with open(label_level_file, 'w') as f:
+    # `newline=''` is used to avoid index error of out of bounds
+    # in Windows system
+    with open(label_level_file, 'w', newline='') as f:
         f_csv = csv.writer(f)
         f_csv.writerow(header)
         f_csv.writerows(annotations)
@@ -129,22 +135,27 @@ def _creat_oid_challenge_style_ann(txt_file, label_file, label_level_file):
         '1 0.0333333 0.1 0.0333333 0.1 1\n',
         '1 0.1 0.166667 0.1 0.166667 0\n',
     ]
-
-    with open(txt_file, 'w') as f:
+    # `newline=''` is used to avoid index error of out of bounds
+    # in Windows system
+    with open(txt_file, 'w', newline='') as f:
         f.writelines(bboxes)
         f.close()
 
     label_description = [['/m/000000', 'Sports equipment', 1],
                          ['/m/000001', 'Ball', 2],
                          ['/m/000002', 'Football', 3],
                          ['/m/000004', 'Bicycle', 4]]
-    with open(label_file, 'w') as f:
+    # `newline=''` is used to avoid index error of out of bounds
+    # in Windows system
+    with open(label_file, 'w', newline='') as f:
         f_csv = csv.writer(f)
         f_csv.writerows(label_description)
 
     header = ['ImageID', 'LabelName', 'Confidence']
     annotations = [['color', '/m/000001', '1'], ['color', '/m/000000', '0']]
-    with open(label_level_file, 'w') as f:
+    # `newline=''` is used to avoid index error of out of bounds
+    # in Windows system
+    with open(label_level_file, 'w', newline='') as f:
         f_csv = csv.writer(f)
         f_csv.writerow(header)
         f_csv.writerows(annotations)