Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .github/workflow/stale.yml #8445

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Add .github/workflow/stale.yml #8445

merged 3 commits into from
Aug 1, 2022

Conversation

lyq10085
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add a new feature to repo's CI:
1.automatically add "stale" label to inactive issues and prs with both "invalid" and "awaiting response" labels
2.automatically close issues and prs which are labeled "stale" for a certain amount of time.

Modification

Add .github/workflow/stale.yml

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

see Close stale issues

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

steps:
- uses: actions/stale@v4
with:
stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the phrases according to #8002

close-issue-message: 'This issue was closed because it has been stalled for 5 days with no activity.'
close-pr-message: 'This PR was closed because it has been stalled for 10 days with no activity.'
# only issues/PRS with ALL these labels are checked
only-labels: 'invalid, awaiting response'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the issues and pr with both invalid and awaiting response labels will be checked.
Suppose I to change current strategy to check issues and prs with any of "invalid" and "awaiting response" labels?
According to #8002 prompt message: "This issue is marked as stale because it has been marked as invalid or awaiting response for 7 days without any further response. It will be closed in 5 days if the stale label is not removed or if there is no further response.", it seems better to do so. @ZwwWayne

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sometimes the issue will not be labeled by both of these two labels. Therefore, 'or' might be more appripriate

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have accomplished the change @ZwwWayne

now, issues and prs with any of 'invalid', 'awaiting response' will be checked
@ZwwWayne ZwwWayne merged commit af145e9 into open-mmlab:dev Aug 1, 2022
ZwwWayne pushed a commit that referenced this pull request Sep 9, 2022
* Add .github/workflow/stale.yml

* modify prompt message in stale.yml

* modify check strategy 

now, issues and prs with any of 'invalid', 'awaiting response' will be checked
triple-Mu pushed a commit to triple-Mu/mmdetection that referenced this pull request Nov 5, 2022
* Add .github/workflow/stale.yml

* modify prompt message in stale.yml

* modify check strategy 

now, issues and prs with any of 'invalid', 'awaiting response' will be checked
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
* Add .github/workflow/stale.yml

* modify prompt message in stale.yml

* modify check strategy 

now, issues and prs with any of 'invalid', 'awaiting response' will be checked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants