Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DyDCNv2 RuntimeError #8485

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Fix DyDCNv2 RuntimeError #8485

merged 1 commit into from
Aug 9, 2022

Conversation

BubblyYi
Copy link

@BubblyYi BubblyYi commented Aug 3, 2022

the parameter of offset is not set as continuous will trigger the runtime error: offset must be continuous

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

the parameter of offset is not set as continuous will trigger the runtime error: offset must be continuous
@CLAassistant
Copy link

CLAassistant commented Aug 3, 2022

CLA assistant check
All committers have signed the CLA.

@jbwang1997
Copy link
Collaborator

Hello @BubblyYi, thanks for your contributions. Could you provide the error report before this modification?

@BubblyYi
Copy link
Author

BubblyYi commented Aug 4, 2022

Hello @BubblyYi, thanks for your contributions. Could you provide the error report before this modification?
As you can see, this bug can be reproduced in torch==1.3.0, mmcv==1.3.9,
WXWorkCapture_16595835706370

Copy link
Collaborator

@BIGWangYuDong BIGWangYuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BIGWangYuDong
Copy link
Collaborator

This PR is to fix errors in lower version PyTorch, which will not affect high version PyTorch

@ZwwWayne ZwwWayne changed the base branch from master to dev August 9, 2022 05:48
@ZwwWayne ZwwWayne merged commit ea5c587 into open-mmlab:dev Aug 9, 2022
ZwwWayne pushed a commit that referenced this pull request Sep 9, 2022
the parameter of offset is not set as continuous will trigger the runtime error: offset must be continuous
triple-Mu pushed a commit to triple-Mu/mmdetection that referenced this pull request Nov 5, 2022
the parameter of offset is not set as continuous will trigger the runtime error: offset must be continuous
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
the parameter of offset is not set as continuous will trigger the runtime error: offset must be continuous
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants