Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repeat] CascadeRPNHead #8578

Merged
merged 1 commit into from
Aug 19, 2022
Merged

[repeat] CascadeRPNHead #8578

merged 1 commit into from
Aug 19, 2022

Conversation

ceasona
Copy link

@ceasona ceasona commented Aug 17, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

CascadeRPNHead repeat.

Modification

Remove duplicate class name.

BC-breaking (Optional)

No.

Use cases (Optional)

No.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2022

CLA assistant check
All committers have signed the CLA.

@jbwang1997 jbwang1997 changed the base branch from master to dev August 17, 2022 08:44
@jbwang1997
Copy link
Collaborator

Thank you very much for your contributions. I see the lint seems not to pass. Please refer to CONTRIBUTING.md to install the pre-commit which can fix the lint error automatically.

And please remember to sign CLA above.
image

@ceasona
Copy link
Author

ceasona commented Aug 17, 2022

I have signed the CLA already but the status is still pending

@jbwang1997
Copy link
Collaborator

jbwang1997 commented Aug 17, 2022

Seems the user information is not correct. You can try to set git config user.email and git config user.name as your name and email of github and make a new pr.
image

@BIGWangYuDong
Copy link
Collaborator

Got same problem in branch dev-3.x.

@ZwwWayne ZwwWayne merged commit c1154e9 into open-mmlab:dev Aug 19, 2022
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
@yaqi0510
Copy link

Dear ceasona,

First of all, we want to express our gratitude for your significant PR in the MMDetection project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG
Thank you again for your contribution❤

Best regards!@ceasona

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants