Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespaced validation logs to prevent overwriting #9662

Closed

Conversation

eantono
Copy link

@eantono eantono commented Jan 24, 2023

Motivation

The validation loss is currently not logged in the setting of both train and val workflow modes.

The problem is described in this issue:
open-mmlab/mmsegmentation#1396
This PR replicates the changes made in this PR to the mmsegmentation library: open-mmlab/mmsegmentation#1494

Modification

val_step is modified to add _val suffix to all validation losses, to distinguish those losses from those in the training step. This enables both training and validation loss logging.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Erin Antono seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@eantono eantono closed this Jan 24, 2023
@eantono eantono deleted the eantono/fix-validation-loss-logging branch January 24, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants