Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmdet3d coordinate for gt boxes are xyzlwh, here in CenterFormer, gtboxes[3] should be length not width. #2360

Open
3 tasks done
DezeZhao opened this issue Mar 16, 2023 · 4 comments

Comments

@DezeZhao
Copy link
Contributor

Prerequisite

Task

I'm using the official example scripts/configs for the officially supported tasks/models/datasets.

Branch

master branch https://github.com/open-mmlab/mmdetection3d

Environment

no

Reproduces the problem - code sample

Reproduces the problem - command or script

Reproduces the problem - error message

Additional information

@JingweiZhang12
Copy link
Contributor

@DezeZhao, Hi, thanks for your kind reminder. It's a minor flaw. Fortunately, it has not related to the precision considering the detailed implements among this:

.
Anyway, could you create a PR to fix it (include here: https://github.com/open-mmlab/mmdetection3d/blob/341ff9980f/mmdet3d/models/dense_heads/centerpoint_head.py#L522)

@DezeZhao
Copy link
Contributor Author

yeah, I got it later. It is ok if these 2 values corresponding to x and y axis and keep their order.

DezeZhao added a commit to DezeZhao/mmdetection3d that referenced this issue Mar 17, 2023
ZwwWayne pushed a commit that referenced this issue Mar 20, 2023
@selmadeac
Copy link

Are you sure this is an issue? length should be larger than width, right?
If i print this in the original implementation it is ok.

if legth>width:
print("TRUE")

@DezeZhao
Copy link
Contributor Author

DezeZhao commented Mar 20, 2023

In mmdetection3d, gt boxes are organized by xyzlwhr order, and length may not always more than width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants