Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new update in dev branch:Fix waymo converter to save img in .jpg(offical in waymo open) reduce dataset from 3.3T to 1.1T #1759

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

zzj403
Copy link

@zzj403 zzj403 commented Aug 23, 2022

Motivation

This PR follows the PR in #1690
Just change branch to dev

Modification

I modifed the save_image function in class Waymo2KITTI
in tools/data_converter/waymo_converter.py

To make the generated ***.pkl to remember the image's file_tail is .jpg. I modified the get_image_path function in tools/data_converter/kitti_data_utils.py, add a file_tail(default='.png') param for it to make the .jpg file_tail be able to be passed in. Besides, this willnot disturb the usage for KITTI processing.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zzj403
Copy link
Author

zzj403 commented Oct 17, 2022

hi need review here~ anyone saw me? _

@JingweiZhang12
Copy link
Contributor

@zzj403 Thanks for your PR. We have already tried this feature in dev-1.x branch. Indeed, it reduces the storage size of the dataset greatly.

@ZwwWayne ZwwWayne merged commit 535f248 into open-mmlab:dev Oct 27, 2022
ZwwWayne pushed a commit to ZwwWayne/mmdetection3d that referenced this pull request Dec 16, 2022
ZwwWayne pushed a commit that referenced this pull request Dec 16, 2022
@OpenMMLab-Assistant005
Copy link

Hi @zzj403 !First of all, we want to express our gratitude for your significant PR in the MMDet3d project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants