Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix ImVoxelNet and KittiMetric & refactor configs of ImVoxelNet #1843

Merged
merged 4 commits into from
Sep 22, 2022

Conversation

JingweiZhang12
Copy link
Contributor

@JingweiZhang12 JingweiZhang12 commented Sep 16, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix some bugs in ImVoxelNet and KittiMetric, simplify the configs of ImVoxelNet and replace all convert_to_datasample with add_pred_to_datasample for keeping consistency with mmdet

Modification

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@JingweiZhang12 JingweiZhang12 changed the title [Fix] Fix ImVoxelNet and KittiMetric & Refactor configs of ImVoxelNet [Fix] Fix ImVoxelNet and KittiMetric & refactor configs of ImVoxelNet Sep 16, 2022
@Tai-Wang Tai-Wang added the 1.x label Sep 21, 2022
@Tai-Wang Tai-Wang merged commit 6607f2a into open-mmlab:dev-1.x Sep 22, 2022
@JingweiZhang12 JingweiZhang12 deleted the fix_imvoxelnet branch November 1, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants