Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PonitRCNN GPU memory occupancy problem #1928

Merged
merged 4 commits into from
Oct 26, 2022

Conversation

VVsssssk
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix PonitRCNN GPU memory occupancy problem. Issue #1907

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@VVsssssk VVsssssk added the bug Something isn't working label Oct 18, 2022
@VVsssssk
Copy link
Collaborator Author

issue #1907

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 49.96% // Head: 49.96% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d55dbdb) compared to base (b9f6e62).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1928   +/-   ##
=======================================
  Coverage   49.96%   49.96%           
=======================================
  Files         228      228           
  Lines       19915    19915           
  Branches     3187     3187           
=======================================
+ Hits         9950     9951    +1     
+ Misses       9375     9374    -1     
  Partials      590      590           
Flag Coverage Δ
unittests 49.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...odels/roi_heads/bbox_heads/point_rcnn_bbox_head.py 30.31% <100.00%> (+0.13%) ⬆️
mmdet3d/models/roi_heads/point_rcnn_roi_head.py 26.66% <100.00%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZCMax
Copy link
Collaborator

ZCMax commented Oct 18, 2022

please fix the ut

@ZwwWayne ZwwWayne merged commit c10107b into open-mmlab:dev Oct 26, 2022
ZwwWayne pushed a commit to ZwwWayne/mmdetection3d that referenced this pull request Dec 16, 2022
* fix pointrcnn oom

* fix

* fix commenst

* fix parta2 ut
ZwwWayne pushed a commit that referenced this pull request Dec 16, 2022
* fix pointrcnn oom

* fix

* fix commenst

* fix parta2 ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants