Skip to content

[Fix] Fix piece_expected_num in IoUNegPiecewiseSampler #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingweiZhang12 merged 2 commits into from
Nov 17, 2022
Merged

[Fix] Fix piece_expected_num in IoUNegPiecewiseSampler #2017

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9e350e
Update iou_neg_piecewise_sampler.py
oyel Nov 11, 2022
a64c6a5
fix lint
JingweiZhang12 Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions mmdet3d/models/task_modules/samplers/iou_neg_piecewise_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Copyright (c) OpenMMLab. All rights reserved.
import math

import torch

from mmdet3d.registry import TASK_UTILS
Expand Down Expand Up @@ -74,9 +76,11 @@ def _sample_neg(self, assign_result, num_expected, **kwargs):
# if the numbers of negative samplers in previous
# pieces are less than the expected number, extend
# the same number in the current piece.
piece_expected_num = int(
num_expected *
self.neg_piece_fractions[piece_inds]) + extend_num
piece_expected_num = min(
num_expected,
math.ceil(num_expected *
self.neg_piece_fractions[piece_inds]) +
extend_num)
min_iou_thr = self.neg_iou_thr[piece_inds + 1]
max_iou_thr = self.neg_iou_thr[piece_inds]
piece_neg_inds = torch.nonzero(
Expand Down