Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix memory overflow in the rotated box IoU calculation #2134

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

JingweiZhang12
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev-1.x@84b4348). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-1.x    #2134   +/-   ##
==========================================
  Coverage           ?   45.30%           
==========================================
  Files              ?      255           
  Lines              ?    20825           
  Branches           ?     3288           
==========================================
  Hits               ?     9434           
  Misses             ?    10771           
  Partials           ?      620           
Flag Coverage Δ
unittests 45.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JingweiZhang12 JingweiZhang12 requested review from VVsssssk and ZCMax and removed request for VVsssssk December 13, 2022 01:44
Copy link
Collaborator

@VVsssssk VVsssssk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 68ef1d7 into open-mmlab:dev-1.x Dec 16, 2022
@JingweiZhang12 JingweiZhang12 deleted the fix_iou3d branch January 11, 2023 14:33
@filaPro
Copy link
Contributor

filaPro commented Mar 7, 2023

Btw, @JingweiZhang12
Do you remember the reason why this commit should fix the memory issue? And why it was (almost?) ok before this commit?

Actually last commit to this line before your commit was mine:) We are probably facing memory issue here now, but not sure. May be will check in the future.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants