Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix part of fcos3d and pgd configs #2191

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

ZCMax
Copy link
Collaborator

@ZCMax ZCMax commented Jan 4, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZCMax ZCMax requested a review from Tai-Wang January 4, 2023 11:44
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 45.23% // Head: 45.11% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (87c0c2d) compared to base (edc468b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2191      +/-   ##
===========================================
- Coverage    45.23%   45.11%   -0.13%     
===========================================
  Files          253      253              
  Lines        20729    20683      -46     
  Branches      3275     3275              
===========================================
- Hits          9377     9331      -46     
  Misses       10733    10733              
  Partials       619      619              
Flag Coverage Δ
unittests 45.11% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/segmentors/base.py 44.89% <0.00%> (-7.74%) ⬇️
...det3d/models/dense_heads/base_mono3d_dense_head.py 31.25% <0.00%> (-2.75%) ⬇️
mmdet3d/models/dense_heads/fcaf3d_head.py 14.01% <0.00%> (-2.23%) ⬇️
mmdet3d/models/layers/norm.py 26.76% <0.00%> (-2.01%) ⬇️
mmdet3d/models/losses/rotated_iou_loss.py 48.00% <0.00%> (-2.00%) ⬇️
mmdet3d/models/detectors/two_stage.py 43.93% <0.00%> (-1.65%) ⬇️
mmdet3d/datasets/transforms/dbsampler.py 13.15% <0.00%> (-1.13%) ⬇️
mmdet3d/structures/det3d_data_sample.py 97.77% <0.00%> (-0.47%) ⬇️
mmdet3d/models/decode_heads/decode_head.py 77.55% <0.00%> (-0.45%) ⬇️
...t3d/models/data_preprocessors/data_preprocessor.py 43.13% <0.00%> (-0.37%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit bd1525e into open-mmlab:dev-1.x Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants