-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add TR3D detector to projects #2274
Conversation
Hi @filaPro , |
Codecov ReportBase: 46.39% // Head: 47.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2274 +/- ##
===========================================
+ Coverage 46.39% 47.09% +0.69%
===========================================
Files 259 261 +2
Lines 21401 21679 +278
Branches 3379 3425 +46
===========================================
+ Hits 9930 10210 +280
+ Misses 10827 10816 -11
- Partials 644 653 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Overall, this PR LGTM. |
Hi @filaPro , |
Hi @filaPro , I have uploaded the checkpoints and logs to our server. You can update the links following the template "https://download.openmmlab.com/mmdetection3d/v1.1.0_models/tr3d/xxx/xxx.log.json", like "https://download.openmmlab.com/mmdetection3d/v1.1.0_models/tr3d/tr3d_1xb16_scannet-3d-18class/tr3d_1xb16_scannet-3d-18class.log.json". BTW, could you please revise the config folder name from "TR3D" to "tr3d" to make it consistent with others? |
Hi @Tai-Wang , |
Sorry, the current name should be ok in projects. Only need to change the config folder name to "tr3d" when we integrate these code into the core codes of mmdet3d. |
Thanks for your PR, it LGTM for me to be merged into projects |
* first tr3d commit * all tr3d files added * all tr3d is ok * fix comments * fix config imports and readme * fix comments * update links in readme * fix lint
Modification
Add TR3D detector in ScanNet, SUN RGB-D and S3DIS to
projects/TR3D
.BC-breaking (Optional)
No