Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add MinkUNet segmentor #2294

Merged
merged 74 commits into from
Mar 23, 2023
Merged

Conversation

sunjiahao1999
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

  1. Add minkunet voxelization
  2. Add minkunet backbone
  3. Add minkunet decode head
  4. Add torchsparse optional backend

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@filaPro
Copy link
Contributor

filaPro commented Feb 18, 2023

Btw, do we want to set different names to resnet and unet models based on torchsparse (in this PR), minkowskiengine (in MinkResNet class and I'm also thinking on adding TD3D segmentor with MinkUNet) and spconv (in SparseUNet class)?

mmdet3d/models/backbones/minkunet_backbone.py Outdated Show resolved Hide resolved
mmdet3d/models/data_preprocessors/data_preprocessor.py Outdated Show resolved Hide resolved
mmdet3d/models/data_preprocessors/data_preprocessor.py Outdated Show resolved Hide resolved
mmdet3d/models/decode_heads/minkunet_head.py Outdated Show resolved Hide resolved
mmdet3d/models/segmentors/minkunet.py Outdated Show resolved Hide resolved
@ZCMax
Copy link
Collaborator

ZCMax commented Mar 22, 2023

minor comments to be fixed and then I'll approve the PR

@ZwwWayne ZwwWayne merged commit ee6cc04 into open-mmlab:dev-1.x Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants