Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support format_only for LyftDataset. #2333

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

Xiangxu-0103
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

  • Support format_only for LyftDataset
  • Update docstring.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 16.00% and project coverage change: -0.02 ⚠️

Comparison is base (cf6f473) 46.86% compared to head (39f8be1) 46.85%.

❗ Current head 39f8be1 differs from pull request most recent head ff6f05f. Consider uploading reports for the commit ff6f05f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2333      +/-   ##
===========================================
- Coverage    46.86%   46.85%   -0.02%     
===========================================
  Files          264      264              
  Lines        22173    22177       +4     
  Branches      3482     3484       +2     
===========================================
- Hits         10392    10391       -1     
- Misses       11118    11123       +5     
  Partials       663      663              
Flag Coverage Δ
unittests 46.85% <16.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/evaluation/metrics/instance_seg_metric.py 94.44% <ø> (ø)
mmdet3d/evaluation/metrics/kitti_metric.py 9.09% <0.00%> (ø)
mmdet3d/evaluation/metrics/nuscenes_metric.py 11.43% <0.00%> (ø)
mmdet3d/evaluation/metrics/waymo_metric.py 8.11% <0.00%> (ø)
mmdet3d/evaluation/metrics/lyft_metric.py 16.36% <12.50%> (-1.14%) ⬇️
mmdet3d/evaluation/metrics/indoor_metric.py 60.65% <50.00%> (+0.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xiangxu-0103 Xiangxu-0103 requested a review from ZCMax March 10, 2023 00:32
@ZwwWayne ZwwWayne merged commit 0c22c62 into open-mmlab:dev-1.x Mar 15, 2023
@Xiangxu-0103 Xiangxu-0103 deleted the support_format_only branch March 22, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants