Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update pre-commit-config-zh-cn.yaml and add typehints for PointNet2SAMSG #2396

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

chriscarving
Copy link
Contributor

…Net2SAMSG

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

  • the original .pre-commit-config-zh-cn.yaml is not equal to pre-commit-config.yaml, it makes code change after commit when using precommit.
  • add mmdet3d/models/backbones/pointnet2_sa_msg typehints and fix warnings

Modification

Please briefly describe what modification is made in this PR.

  • remove some repos in .pre-commit-config-zh-cn.yaml
  • add mmdet3d/models/backbones/pointnet2_sa_msg.py typehints
  • add location in mmdet3d/models/layers/pointnet_modules/builder.py

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 54.86% and project coverage change: +0.63 🎉

Comparison is base (d84e081) 46.37% compared to head (47930ac) 47.01%.

❗ Current head 47930ac differs from pull request most recent head 6aa5eae. Consider uploading reports for the commit 6aa5eae to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2396      +/-   ##
===========================================
+ Coverage    46.37%   47.01%   +0.63%     
===========================================
  Files          259      275      +16     
  Lines        21390    22903    +1513     
  Branches      3379     3565     +186     
===========================================
+ Hits          9919    10767     +848     
- Misses       10827    11450     +623     
- Partials       644      686      +42     
Flag Coverage Δ
unittests 47.01% <54.86%> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/s3dis_dataset.py 78.08% <ø> (ø)
mmdet3d/datasets/scannet_dataset.py 82.75% <ø> (ø)
mmdet3d/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/waymo_dataset.py 17.72% <ø> (ø)
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
...tion/functional/waymo_utils/prediction_to_waymo.py 0.00% <0.00%> (ø)
mmdet3d/evaluation/metrics/instance_seg_metric.py 94.44% <ø> (ø)
mmdet3d/evaluation/metrics/seg_metric.py 62.50% <0.00%> (ø)
mmdet3d/evaluation/metrics/waymo_metric.py 8.11% <0.00%> (ø)
mmdet3d/models/dense_heads/centerpoint_head.py 21.77% <0.00%> (ø)
... and 73 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JingweiZhang12 JingweiZhang12 changed the title [Fix] Update pre-commit-config-zh-cn.yaml and add typehints for Point… [Fix] Update pre-commit-config-zh-cn.yaml and add typehints for PointNet2SAMSG Apr 10, 2023
@ZwwWayne ZwwWayne merged commit 4ff1361 into open-mmlab:dev-1.x Apr 12, 2023
@OpenMMLab-Assistant-007

Hi @chriscarving
We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants