Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] np.float as it is deprecated #2527

Merged
merged 1 commit into from
May 17, 2023
Merged

[Fix] np.float as it is deprecated #2527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mmdet3d/evaluation/functional/scannet_utils/evaluate_semantic_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ def evaluate_matches(matches, class_labels, options):
dist_confs = [options['distance_confs'][0]]

# results: class x overlap
ap = np.zeros((len(dist_threshes), len(class_labels), len(overlaps)),
np.float)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to change np.float to np.float32

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the default dtype for np.zeros is float which according to numpy documentation means exactly the same as old np.float. Why do we want to specify np.float32?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We expect to keep dtype to make the code more readable.

ap = np.zeros((len(dist_threshes), len(class_labels), len(overlaps)))
for di, (min_region_size, distance_thresh, distance_conf) in enumerate(
zip(min_region_sizes, dist_threshes, dist_confs)):
for oi, overlap_th in enumerate(overlaps):
Expand Down