Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some problem in getting_started.md #269

Merged
merged 1 commit into from
Jan 18, 2021
Merged

fix some problem in getting_started.md #269

merged 1 commit into from
Jan 18, 2021

Conversation

wikiwen
Copy link
Contributor

@wikiwen wikiwen commented Jan 16, 2021 •
edited
Loading

When I try to install mmdetection3d according to doc getting_started.md, I met some problem:

  1. pytorch install comand in e.g. 1 will install latest version not 1.5.0 as stated above.
  2. mmcv-full install command failed with "Invalid version".

I correct these little problem and set step titles bold to make them more clear.

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #269 (fa4466c) into master (bd44491) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #269   +/-   ##
=======================================
  Coverage   49.89%   49.89%           
=======================================
  Files         172      172           
  Lines       11571    11571           
  Branches     1802     1802           
=======================================
  Hits         5773     5773           
  Misses       5424     5424           
  Partials      374      374
Flag Coverage Δ
unittests 49.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd44491...fa4466c. Read the comment docs.

@ZwwWayne
Copy link
Collaborator

Great, thanks for your kind contribution.

@ZwwWayne ZwwWayne merged commit cda3e0e into open-mmlab:master Jan 18, 2021
SimonDoll pushed a commit to SimonDoll/mmdetection3d that referenced this pull request Mar 7, 2021
@wikiwen @SimonDoll
Fix some problems in getting_started.md (open-mmlab#269)
784ac10
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
@hanrui1sensetime
[Fix] fix bugs for mmcls performance test (open-mmlab#269)
0f90a0a 
* fix bugs for mmcls performance test

* fix yapf

* add comments of CLASSES attribute
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
@SemyonBevzuk @hanrui1sensetime
[Fix] Fix VFNet test (open-mmlab#281)
a96e5f9 
* [Fix] fix bugs for mmcls performance test (open-mmlab#269)

* fix bugs for mmcls performance test

* fix yapf

* add comments of CLASSES attribute

* Fix test_get_bboxes_of_vfnet_head

* Fix

Co-authored-by: hanrui1sensetime <83800577+hanrui1sensetime@users.noreply.github.com>
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
@SemyonBevzuk @hanrui1sensetime @AllentDan
[Fix] Fix input names (open-mmlab#12)
8cdb4ab 
* [Fix] fix bugs for mmcls performance test (open-mmlab#269)

* fix bugs for mmcls performance test

* fix yapf

* add comments of CLASSES attribute

* Fix input name

* support all codebases and update dump info

* fix docstring

* Added random names.

* onnx_config -> ir_config

* fix test

* fix test

* add a TODO

* use self.output_names

* Fixes

* Rewrite test_torch2onnx.

Co-authored-by: hanrui1sensetime <83800577+hanrui1sensetime@users.noreply.github.com>
Co-authored-by: AllentDan <AllentDan@yeah.net>
Co-authored-by: grimoire <yaoqian@sensetime.com>
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
@SemyonBevzuk @hanrui1sensetime @AllentDan
[Refactoring]: Add get_dynamic_axes. (open-mmlab#36)
3fd17ab 
* [Fix] fix bugs for mmcls performance test (open-mmlab#269)

* fix bugs for mmcls performance test

* fix yapf

* add comments of CLASSES attribute

* Fix input name

* support all codebases and update dump info

* fix docstring

* Added random names.

* onnx_config -> ir_config

* fix test

* fix test

* add a TODO

* use self.output_names

* Fixes

* Rewrite test_torch2onnx.

* Add get_dynamic_axes.

* Fix TestGetDynamicAxes

Co-authored-by: hanrui1sensetime <83800577+hanrui1sensetime@users.noreply.github.com>
Co-authored-by: AllentDan <AllentDan@yeah.net>
Co-authored-by: grimoire <yaoqian@sensetime.com>
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
@SemyonBevzuk @hanrui1sensetime
[Fix] Fixed device_id in tools/test.py for the CPU. (open-mmlab#58)
997d111 
* [Fix] fix bugs for mmcls performance test (open-mmlab#269)

* fix bugs for mmcls performance test

* fix yapf

* add comments of CLASSES attribute

* Rewrote the dictionary traversal for new versions of Python.

* Fix device_id for cpu

* Rewrite parse_device_id and tests

* Added None for cpu

Co-authored-by: hanrui1sensetime <83800577+hanrui1sensetime@users.noreply.github.com>
@OpenMMLab-Assistant-007
Copy link

Hi!
@wikiwen
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA

If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tai-Wang Tai-Wang Tai-Wang approved these changes

@ZwwWayne ZwwWayne ZwwWayne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wikiwen @CLAassistant @ZwwWayne @OpenMMLab-Assistant-007 @Tai-Wang