Fix miss text #278
Fix miss text #278
Conversation
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 49.89% 50.09% +0.20%
==========================================
Files 172 172
Lines 11571 11572 +1
Branches 1802 1802
==========================================
+ Hits 5773 5797 +24
+ Misses 5424 5409 -15
+ Partials 374 366 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| classes = ['Pedestrian', 'Cyclist', 'Car'] | ||
| pts_prefix = 'velodyne_reduced' | ||
| pipeline = [{ | ||
| 'type': 'LoadPointsFromFile', |
There was a problem hiding this comment.
Can we use dict() to make this part simpler and following the convention?
| pts_prefix, | ||
| pipeline, | ||
| classes, | ||
| modality, |
| result = dict(boxes_3d=boxes_3d, labels_3d=labels_3d, scores_3d=scores_3d) | ||
| results = [result] | ||
| temp_kitti_result_dir = tempfile.mkdtemp() | ||
| print(temp_kitti_result_dir) |
There was a problem hiding this comment.
I am sorry to forget to delete the debug code
| classes, | ||
| modality, | ||
| ) | ||
| boxes_3d = LiDARInstance3DBoxes( |
There was a problem hiding this comment.
May also test empty boxes to verify the bug is fixed.
There was a problem hiding this comment.
The empty boxes test code at line 387
| }] | ||
| }] | ||
| modality = {'use_lidar': True, 'use_camera': False} | ||
| pipeline = [ |
There was a problem hiding this comment.
It seems that similar pipeline are generated and used multiple times. Can we implement a new function to generate it and reduce code?
* compatible trt version for dbnet * judge inside rewrite
* suppress CMAKE_CUDA_ARCHITECTURES warning * refactor
Fix a bug, Miss text file when generating test file which will be submitted to test server! #123