Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Lift the NUSC_BOX_TO_CAM_BOX3D dependence on CUDA. #2851

Open
wants to merge 2 commits into
base: dev-1.x
Choose a base branch
from

Conversation

LRJKD
Copy link
Contributor

@LRJKD LRJKD commented Dec 25, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Lift the NUSC_BOX_TO_CAM_BOX3D dependence on CUDA.

Modification

Modified nuscenes_metric.py files.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5c0613b) 46.70% compared to head (adce980) 46.70%.

Files Patch % Lines
mmdet3d/evaluation/metrics/nuscenes_metric.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2851   +/-   ##
=======================================
  Coverage   46.70%   46.70%           
=======================================
  Files         277      277           
  Lines       23635    23635           
  Branches     3704     3704           
=======================================
  Hits        11039    11039           
  Misses      11892    11892           
  Partials      704      704           
Flag Coverage Δ
unittests 46.70% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shun001
Copy link

shun001 commented Dec 25, 2023

/lgtm

@Xiangxu-0103 Xiangxu-0103 changed the base branch from main to dev-1.x December 26, 2023 06:14
@shun001
Copy link

shun001 commented Jan 16, 2024

Squash and merge

@shun001
Copy link

shun001 commented Feb 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants