Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] SemanticKITTI Dataset #287

Merged
merged 13 commits into from
Feb 1, 2021
Merged

Conversation

junhaozhang98
Copy link
Contributor

1)ini add
2)semantickitti_datset
3)test data

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2021

CLA assistant check
All committers have signed the CLA.

@Tai-Wang Tai-Wang self-requested a review January 27, 2021 02:41
@Tai-Wang Tai-Wang changed the title semantickitti_datset [Feature] SemanticKITTI Dataset Jan 27, 2021
@ZwwWayne
Copy link
Collaborator

Please sign CLA and fix CI.

@ZwwWayne
Copy link
Collaborator

tests/data/semantickitti/sequences/00/velodyne/000000.bin is too large. We need to make the uploaded file as small as possible to reduce the repo size for the convenience of download.

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #287 (ffb082c) into master (87b05ba) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   50.09%   50.22%   +0.13%     
==========================================
  Files         172      173       +1     
  Lines       11572    11587      +15     
  Branches     1802     1803       +1     
==========================================
+ Hits         5797     5820      +23     
+ Misses       5409     5406       -3     
+ Partials      366      361       -5     
Flag Coverage Δ
unittests 50.22% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/__init__.py 100.00% <100.00%> (ø)
mmdet3d/datasets/pipelines/loading.py 74.16% <100.00%> (+1.78%) ⬆️
mmdet3d/datasets/semantickitti_dataset.py 100.00% <100.00%> (ø)
mmdet3d/datasets/pipelines/transforms_3d.py 84.03% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b05ba...78ae4e3. Read the comment docs.

@ZwwWayne ZwwWayne merged commit b050172 into open-mmlab:master Feb 1, 2021
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* add docs

* update

* update

* resolve comments
@OpenMMLab-Assistant-007
Copy link

Hi!
@junhaozhang98
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants