Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix typos and error in comments #308

Merged
merged 3 commits into from
Feb 17, 2021
Merged

[Fix] Fix typos and error in comments #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99e2f7f
fix bug caused by mmcv upgrade; delete pdb breakpoint
yezhen17 Feb 10, 2021
e9c6df3
Merge branch 'master_fork'
yezhen17 Feb 16, 2021
cb23822
fix typos
yezhen17 Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configs/_base_/models/centerpoint_01voxel_second_secfpn_nus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
out_size_factor=8,
voxel_size=voxel_size[:2],
code_size=9),
seperate_head=dict(
separate_head=dict(
type='SeparateHead', init_bias=-2.19, final_kernel=3),
loss_cls=dict(type='GaussianFocalLoss', reduction='mean'),
loss_bbox=dict(type='L1Loss', reduction='mean', loss_weight=0.25),
Expand Down
2 changes: 1 addition & 1 deletion configs/_base_/models/centerpoint_02pillar_second_secfpn_nus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
out_size_factor=4,
voxel_size=voxel_size[:2],
code_size=9),
seperate_head=dict(
separate_head=dict(
type='SeparateHead', init_bias=-2.19, final_kernel=3),
loss_cls=dict(type='GaussianFocalLoss', reduction='mean'),
loss_bbox=dict(type='L1Loss', reduction='mean', loss_weight=0.25),
Expand Down
4 changes: 2 additions & 2 deletions configs/centerpoint/centerpoint_0075voxel_second_secfpn_dcn_4x8_cyclic_20e_nus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

model = dict(
pts_bbox_head=dict(
seperate_head=dict(
type='DCNSeperateHead',
separate_head=dict(
type='DCNSeparateHead',
dcn_config=dict(
type='DCN',
in_channels=64,
Expand Down
4 changes: 2 additions & 2 deletions configs/centerpoint/centerpoint_0075voxel_second_secfpn_dcn_circlenms_4x8_cyclic_20e_nus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

model = dict(
pts_bbox_head=dict(
seperate_head=dict(
type='DCNSeperateHead',
separate_head=dict(
type='DCNSeparateHead',
dcn_config=dict(
type='DCN',
in_channels=64,
Expand Down
4 changes: 2 additions & 2 deletions configs/centerpoint/centerpoint_01voxel_second_secfpn_dcn_4x8_cyclic_20e_nus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

model = dict(
pts_bbox_head=dict(
seperate_head=dict(
type='DCNSeperateHead',
separate_head=dict(
type='DCNSeparateHead',
dcn_config=dict(
type='DCN',
in_channels=64,
Expand Down
4 changes: 2 additions & 2 deletions configs/centerpoint/centerpoint_01voxel_second_secfpn_dcn_circlenms_4x8_cyclic_20e_nus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

model = dict(
pts_bbox_head=dict(
seperate_head=dict(
type='DCNSeperateHead',
separate_head=dict(
type='DCNSeparateHead',
dcn_config=dict(
type='DCN',
in_channels=64,
Expand Down
4 changes: 2 additions & 2 deletions configs/centerpoint/centerpoint_02pillar_second_secfpn_dcn_4x8_cyclic_20e_nus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

model = dict(
pts_bbox_head=dict(
seperate_head=dict(
type='DCNSeperateHead',
separate_head=dict(
type='DCNSeparateHead',
dcn_config=dict(
type='DCN',
in_channels=64,
Expand Down
4 changes: 2 additions & 2 deletions configs/centerpoint/centerpoint_02pillar_second_secfpn_dcn_circlenms_4x8_cyclic_20e_nus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

model = dict(
pts_bbox_head=dict(
seperate_head=dict(
type='DCNSeperateHead',
separate_head=dict(
type='DCNSeparateHead',
dcn_config=dict(
type='DCN',
in_channels=64,
Expand Down
14 changes: 7 additions & 7 deletions mmdet3d/models/dense_heads/centerpoint_head.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ def forward(self, x):


@HEADS.register_module()
class DCNSeperateHead(nn.Module):
r"""DCNSeperateHead for CenterHead.
class DCNSeparateHead(nn.Module):
r"""DCNSeparateHead for CenterHead.

.. code-block:: none
/-----> DCN for heatmap task -----> heatmap task.
Expand Down Expand Up @@ -155,7 +155,7 @@ def __init__(self,
norm_cfg=dict(type='BN2d'),
bias='auto',
**kwargs):
super(DCNSeperateHead, self).__init__()
super(DCNSeparateHead, self).__init__()
if 'heatmap' in heads:
heads.pop('heatmap')
# feature adaptation with dcn
Expand Down Expand Up @@ -250,7 +250,7 @@ class CenterHead(nn.Module):
Default: dict(type='GaussianFocalLoss', reduction='mean').
loss_bbox (dict): Config of regression loss function.
Default: dict(type='L1Loss', reduction='none').
seperate_head (dict): Config of seperate head. Default: dict(
separate_head (dict): Config of separate head. Default: dict(
type='SeparateHead', init_bias=-2.19, final_kernel=3)
share_conv_channel (int): Output channels for share_conv_layer.
Default: 64.
Expand All @@ -273,7 +273,7 @@ def __init__(self,
loss_cls=dict(type='GaussianFocalLoss', reduction='mean'),
loss_bbox=dict(
type='L1Loss', reduction='none', loss_weight=0.25),
seperate_head=dict(
separate_head=dict(
type='SeparateHead', init_bias=-2.19, final_kernel=3),
share_conv_channel=64,
num_heatmap_convs=2,
Expand Down Expand Up @@ -312,9 +312,9 @@ def __init__(self,
for num_cls in num_classes:
heads = copy.deepcopy(common_heads)
heads.update(dict(heatmap=(num_cls, num_heatmap_convs)))
seperate_head.update(
separate_head.update(
in_channels=share_conv_channel, heads=heads, num_cls=num_cls)
self.task_heads.append(builder.build_head(seperate_head))
self.task_heads.append(builder.build_head(separate_head))

def init_weights(self):
"""Initialize weights."""
Expand Down
2 changes: 1 addition & 1 deletion mmdet3d/models/fusion_layers/point_fusion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ def sample_single(self, img_feats, pts, img_meta):

Args:
img_feats (torch.Tensor): Image feature map in shape
(N, C, H, W).
(1, C, H, W).
pts (torch.Tensor): Points of a single sample.
img_meta (dict): Meta information of the single sample.

Expand Down
4 changes: 2 additions & 2 deletions tests/test_models/test_forward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
"""Test model forward process.

CommandLine:
pytest tests/test_forward.py
xdoctest tests/test_forward.py zero
pytest tests/test_models/test_forward.py
xdoctest tests/test_models/test_forward.py zero
"""
import copy
import numpy as np
Expand Down
4 changes: 2 additions & 2 deletions tests/test_models/test_heads/test_heads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,8 +806,8 @@ def test_dcn_center_head():
out_size_factor=4,
voxel_size=voxel_size[:2],
code_size=9),
seperate_head=dict(
type='DCNSeperateHead',
separate_head=dict(
type='DCNSeparateHead',
dcn_config=dict(
type='DCN',
in_channels=64,
Expand Down
4 changes: 2 additions & 2 deletions tests/test_utils/test_anchors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""
CommandLine:
pytest tests/test_anchor.py
xdoctest tests/test_anchor.py zero
pytest tests/test_utils/test_anchor.py
xdoctest tests/test_utils/test_anchor.py zero

"""
import torch
Expand Down
4 changes: 2 additions & 2 deletions tests/test_utils/test_assigners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
"""Tests the Assigner objects.

CommandLine:
pytest tests/test_assigner.py
xdoctest tests/test_assigner.py zero
pytest tests/test_utils/test_assigner.py
xdoctest tests/test_utils/test_assigner.py zero
"""
import torch

Expand Down