Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support MoCa #327

Open
wants to merge 2 commits into
base: 1.0
Choose a base branch
from
Open

Conversation

ZwwWayne
Copy link
Collaborator

@ZwwWayne ZwwWayne commented Mar 1, 2021

This is the official code release of paper: Multi-Modality Cut and Paste for 3D Object Detection. This PR includes the implementation of Hybrid Optimizer and multi-modality cut and paste on the KITTI dataset.

@ZwwWayne ZwwWayne requested a review from Tai-Wang March 1, 2021 07:22
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Attention: Patch coverage is 14.42006% with 273 lines in your changes missing coverage. Please review.

Project coverage is 48.97%. Comparing base (391a56b) to head (6641bbf).
Report is 483 commits behind head on 1.0.

Files with missing lines Patch % Lines
mmdet3d/datasets/pipelines/dbsampler.py 4.96% 134 Missing ⚠️
mmdet3d/core/optimizer/hybrid_constructor.py 16.66% 40 Missing ⚠️
mmdet3d/core/optimizer/hybrid_optimizer.py 25.49% 38 Missing ⚠️
mmdet3d/datasets/pipelines/formating.py 30.76% 12 Missing and 6 partials ⚠️
mmdet3d/datasets/pipelines/loading.py 15.78% 16 Missing ⚠️
mmdet3d/models/detectors/mvx_two_stage.py 5.88% 16 Missing ⚠️
mmdet3d/ops/norm.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              1.0     #327      +/-   ##
==========================================
- Coverage   49.71%   48.97%   -0.75%     
==========================================
  Files         181      184       +3     
  Lines       12451    12689     +238     
  Branches     1951     2005      +54     
==========================================
+ Hits         6190     6214      +24     
- Misses       5871     6091     +220     
+ Partials      390      384       -6     
Flag Coverage Δ
unittests 48.97% <14.42%> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


@OBJECTSAMPLERS.register_module()
class MMDataBaseSampler(DataBaseSampler):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for the functions below.

results['img_shape'] = img.shape
results['ori_shape'] = img.shape
# Set initial values for default meta_keys
results['pad_shape'] = img.shape
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other keys like scale_factor and img_norm_cfg are not used any longer?

@@ -77,11 +78,11 @@ def __call__(self, results):
# modified from `flip_aug = [False, True] if self.flip else [False]`
# to reduce unnecessary scenes when using double flip augmentation
# during test time
flip_aug = [True] if self.flip else [False]
flip_aug = [False, True] if self.flip else [False]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a conflict. Please make sure this modification will not affect current models.

Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test may be added in next version.

…a-kitti

Conflicts:
	mmdet3d/models/fusion_layers/point_fusion.py
(w_scale, h_scale).
img_crop_offset (torch.Tensor): Crop offset used to crop \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should keep the '' because it is needed when converting the API documentation?

dist_params = dict(backend='nccl')
log_level = 'INFO'
work_dir = None
# You may need to download the model first is the network is unstable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo 'is the network is unstable'?

@filaPro
Copy link
Contributor

filaPro commented Apr 11, 2021

Looks like kitti_mm_dbinfos_train.pkl is not the same with kitti_dbinfos_train.pkl. Are you going to provide this file or its generating script? Thanks.

@gujiaqivadin
Copy link

Looks like kitti_mm_dbinfos_train.pkl is not the same with kitti_dbinfos_train.pkl. Are you going to provide this file or its generating script? Thanks.

It seems that moca needs instance_train.json which is the instance segmentation results of KITTI train split to produce this file. I also want to know whether moca would provide this file later.
@ZwwWayne Hello, wenwei. Do you have any plans for releasing moca? Or maybe providing a instance_train.json or kitti_mm_dbinfos_train.pkl for pubilic to try some multi-modality 3d methods by our own. Thanks a lot!

tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* start up

* zh-cn v0.1

* [Docs] Add a from-scratch example for "Get Started" (open-mmlab#326)

* Add a from-scratch example

* Fix typo

* resolve comment

* bachslash

* Resolve comments

* Refine commands

* add cn docs

* Correct commands

* fixing...

* update zn-cn docs

* update en link

* add sdk's get-started (open-mmlab#331)

* add sdk's get-started

* add SDK build command

* fix chinglish

* add sdk get start zh_cn

* update zh_cn cite

* fix command

* add selfsup/razor readme

* Fix command

Co-authored-by: Yifan Zhou <singlezombie@163.com>
Co-authored-by: lvhan028 <lvhan_028@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants