Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed] Fix issue #298 #356

Closed
wants to merge 1 commit into from
Closed

Conversation

xiliu8006
Copy link
Contributor

Avoid 4 dims points as the input of points_in_boxes functions(#289 )

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


xiliu8006 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #356 (33e9686) into master (e5f55bd) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   49.69%   49.68%   -0.01%     
==========================================
  Files         174      174              
  Lines       11758    11760       +2     
  Branches     1838     1838              
==========================================
  Hits         5843     5843              
- Misses       5555     5557       +2     
  Partials      360      360              
Flag Coverage Δ
unittests 49.68% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/ops/roiaware_pool3d/points_in_boxes.py 30.30% <0.00%> (-1.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f55bd...853bac1. Read the comment docs.

@xiliu8006 xiliu8006 closed this Mar 12, 2021
@xiliu8006 xiliu8006 deleted the Fix_issue_289 branch March 12, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants