Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed] Fix issue #298 #357

Merged
merged 3 commits into from
Mar 24, 2021
Merged

[Fixed] Fix issue #298 #357

merged 3 commits into from
Mar 24, 2021

Conversation

xiliu8006
Copy link
Contributor

Avoid 4 dims points as the input of points_in_boxes functions

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #357 (0c3074a) into master (e5f55bd) will decrease coverage by 0.15%.
The diff coverage is 27.77%.

❗ Current head 0c3074a differs from pull request most recent head 80899fa. Consider uploading reports for the commit 80899fa to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   49.69%   49.54%   -0.16%     
==========================================
  Files         174      177       +3     
  Lines       11758    11836      +78     
  Branches     1838     1844       +6     
==========================================
+ Hits         5843     5864      +21     
- Misses       5555     5612      +57     
  Partials      360      360              
Flag Coverage Δ
unittests 49.54% <27.77%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/ops/gather_points/gather_points.py 34.78% <0.00%> (ø)
mmdet3d/core/evaluation/seg_eval.py 18.18% <18.18%> (ø)
mmdet3d/ops/roiaware_pool3d/points_in_boxes.py 30.30% <25.00%> (-1.96%) ⬇️
mmdet3d/ops/knn/knn.py 32.14% <32.14%> (ø)
mmdet3d/__init__.py 77.27% <100.00%> (ø)
mmdet3d/core/evaluation/__init__.py 100.00% <100.00%> (ø)
mmdet3d/ops/__init__.py 100.00% <100.00%> (ø)
mmdet3d/ops/knn/__init__.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f55bd...80899fa. Read the comment docs.

@@ -17,6 +17,7 @@ def points_in_boxes_gpu(points, boxes):
"""
assert boxes.shape[0] == points.shape[0]
assert boxes.shape[2] == 7
assert points.shape[2] == 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, f'got unexpected shape {points.shape[2]}'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will modify it

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2021

CLA assistant check
All committers have signed the CLA.

assert boxes.shape[0] == points.shape[0]
assert boxes.shape[2] == 7
assert boxes.shape[0] == points.shape[0], \
'Points and boxes should have the same batch size'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f'Points and boxes should have the same batch size, got {boxes.shape[0]} and {points.shape[0]}'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, I will modify it

@ZwwWayne ZwwWayne merged commit bc97d76 into open-mmlab:master Mar 24, 2021
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* add CUDA_TOOKIT_ROOT_DIR as tensorrt detect dir

* Update FindTENSORRT.cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants