-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixed] Fix issue #298 #357
Conversation
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
==========================================
- Coverage 49.69% 49.54% -0.16%
==========================================
Files 174 177 +3
Lines 11758 11836 +78
Branches 1838 1844 +6
==========================================
+ Hits 5843 5864 +21
- Misses 5555 5612 +57
Partials 360 360
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -17,6 +17,7 @@ def points_in_boxes_gpu(points, boxes): | |||
""" | |||
assert boxes.shape[0] == points.shape[0] | |||
assert boxes.shape[2] == 7 | |||
assert points.shape[2] == 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, f'got unexpected shape {points.shape[2]}'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will modify it
3430bd2
to
122b82f
Compare
assert boxes.shape[0] == points.shape[0] | ||
assert boxes.shape[2] == 7 | ||
assert boxes.shape[0] == points.shape[0], \ | ||
'Points and boxes should have the same batch size' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f'Points and boxes should have the same batch size, got {boxes.shape[0]} and {points.shape[0]}'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, I will modify it
* add CUDA_TOOKIT_ROOT_DIR as tensorrt detect dir * Update FindTENSORRT.cmake
Avoid 4 dims points as the input of points_in_boxes functions