Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support dataset browsing on all datasets #367

Merged
merged 14 commits into from
Apr 8, 2021

Conversation

wHao-Wu
Copy link
Contributor

@wHao-Wu wHao-Wu commented Mar 19, 2021

  • Support dataset browsing on KITTI

  • Saving image of views specified by users when pressing ESC in open3d window

Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an instruction and illustration in the documentation [USEFUL TOOLS...] .

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #367 (8f4f0cd) into master (0c74471) will decrease coverage by 0.00%.
The diff coverage is 41.66%.

❗ Current head 8f4f0cd differs from pull request most recent head ce7f037. Consider uploading reports for the commit ce7f037 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
- Coverage   50.17%   50.17%   -0.01%     
==========================================
  Files         183      184       +1     
  Lines       13165    13177      +12     
  Branches     2095     2097       +2     
==========================================
+ Hits         6606     6611       +5     
- Misses       6123     6130       +7     
  Partials      436      436              
Flag Coverage Δ
unittests 50.17% <41.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/utils.py 36.36% <36.36%> (ø)
mmdet3d/datasets/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c74471...ce7f037. Read the comment docs.

docs/useful_tools.md Outdated Show resolved Hide resolved
docs/useful_tools.md Outdated Show resolved Hide resolved
docs/useful_tools.md Outdated Show resolved Hide resolved
docs/useful_tools.md Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne requested a review from Wuziyi616 March 30, 2021 06:03
@ZwwWayne
Copy link
Collaborator

Please @Wuziyi616 check the functionality of each dataset. The PR can be merged after all datasets could be correctly visualized.

Copy link
Contributor

@Wuziyi616 Wuziyi616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also consider visualizing segmentation/multi-modality detection dataset in the future? I am checking the functionality on all datasets now, it may take a while...

@Wuziyi616 Wuziyi616 changed the title [Enhance] Support dataset browsing on KITTI [Enhance] Support dataset browsing on all datasets Apr 6, 2021
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Apr 6, 2021

We may also consider visualizing segmentation/multi-modality detection dataset in the future? I am checking the functionality on all datasets now, it may take a while...

Yes, we need to consider that. At least the high-level logic and code of each dataset should be unified in MMDet3D.

Copy link
Contributor

@Wuziyi616 Wuziyi616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix some small bugs in the code.

@Wuziyi616
Copy link
Contributor

Wuziyi616 commented Apr 8, 2021

Below are some saved visualization examples of browse_dataset, they cover all three (currently supported) dataset formats.

KITTI:
000007
000010

ScanNet:
scene0191_00
scene0230_00

Lyft:
host-a007_lidar1_1230485630301986856
host-a007_lidar1_1230485630901720976

@ZwwWayne ZwwWayne merged commit 825f47a into open-mmlab:master Apr 8, 2021
@wHao-Wu
Copy link
Contributor Author

wHao-Wu commented Apr 21, 2021

Below are some visualization results for Waymo and SUN RGB-D datasets.

Waymo:

0000010

SUN RGB-D:
005051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants