Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix a bug when adding ('val', 1) to workflow #370

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

yezhen17
Copy link
Collaborator

@yezhen17 yezhen17 commented Mar 20, 2021

Val in workflow is intended to show the losses on test set. This pr fixes a bug when adding val to workflow.

Still, val uses train-time data augmentations, which is not preferred. However, one can slightly modify the config files and train.py in order to use test-time data augmentations for val. Therefore we do not address the issue in this pr. Perhaps some refactors might be considered in the future regarding this issue (the test_mode meaning and pipeline overriding here are also a bit confusing)?

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #370 (8e06812) into master (f0ba0ce) will not change coverage.
The diff coverage is 33.33%.

❗ Current head 8e06812 differs from pull request most recent head 4880ee6. Consider uploading reports for the commit 4880ee6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         177      177           
  Lines       11834    11834           
  Branches     1844     1844           
=======================================
  Hits         5864     5864           
  Misses       5610     5610           
  Partials      360      360           
Flag Coverage Δ
unittests 49.55% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/ops/knn/knn.py 32.14% <0.00%> (ø)
mmdet3d/__init__.py 77.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ba0ce...4880ee6. Read the comment docs.

tools/train.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit 097b66e into open-mmlab:master Mar 24, 2021
@yezhen17 yezhen17 deleted the fix_val_bug branch April 13, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants