Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix potential bug in ThreeNN #377

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

yezhen17
Copy link
Collaborator

Currently this bug won't be triggered in the repo. However, when the indices calculated by ThreeNN participate in backwarding, there will be an error message: RuntimeError: Expected isFloatingType(grads[i].scalar_type()) to be true, but got false.

Please refer to facebookresearch/votenet#72 and https://discuss.pytorch.org/t/custom-autograd-function-with-int-tensor-input/65907.

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #377 (d48f400) into master (22c47ac) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   49.55%   49.54%   -0.01%     
==========================================
  Files         177      177              
  Lines       11834    11835       +1     
  Branches     1844     1844              
==========================================
  Hits         5864     5864              
- Misses       5610     5611       +1     
  Partials      360      360              
Flag Coverage Δ
unittests 49.54% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/ops/interpolate/three_nn.py 50.00% <0.00%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22c47ac...d48f400. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 1feb891 into open-mmlab:master Mar 24, 2021
@yezhen17 yezhen17 deleted the fix_threenn_bug branch April 13, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants