Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Enhance in vfe_layers creation #389

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

zehuichen123
Copy link
Contributor

Move one code out of the for-loop. Mentioned in #383. A re-created PR due to CLA.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #389 (960447f) into master (dabf0a2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   49.71%   49.71%           
=======================================
  Files         181      181           
  Lines       12451    12451           
  Branches     1951     1951           
=======================================
  Hits         6190     6190           
  Misses       5871     5871           
  Partials      390      390           
Flag Coverage Δ
unittests 49.71% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/voxel_encoders/voxel_encoder.py 54.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabf0a2...960447f. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 87ae3d6 into open-mmlab:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants