Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support monocular 3D detection on nuScenes #392

Merged
merged 25 commits into from
Apr 7, 2021

Conversation

Tai-Wang
Copy link
Member

This PR mainly supports related dataset converter and reading/evaluation API.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #392 (9ab6cf3) into master (d055876) will increase coverage by 0.58%.
The diff coverage is 56.25%.

❗ Current head 9ab6cf3 differs from pull request most recent head cd1e015. Consider uploading reports for the commit cd1e015 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   49.73%   50.31%   +0.58%     
==========================================
  Files         181      183       +2     
  Lines       12445    13123     +678     
  Branches     1950     2086     +136     
==========================================
+ Hits         6189     6603     +414     
- Misses       5867     6086     +219     
- Partials      389      434      +45     
Flag Coverage Δ
unittests 50.31% <56.25%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/pipelines/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/pipelines/formating.py 56.00% <0.00%> (+1.26%) ⬆️
mmdet3d/core/bbox/box_np_ops.py 26.81% <9.09%> (-0.88%) ⬇️
mmdet3d/core/evaluation/seg_eval.py 16.32% <12.50%> (-1.86%) ⬇️
mmdet3d/core/post_processing/box3d_nms.py 43.41% <20.00%> (-8.08%) ⬇️
mmdet3d/datasets/nuscenes_mono_dataset.py 32.97% <32.97%> (ø)
mmdet3d/core/bbox/transforms.py 75.00% <60.00%> (-5.96%) ⬇️
mmdet3d/core/visualizer/show_result.py 75.00% <66.66%> (-4.67%) ⬇️
mmdet3d/datasets/custom_3d_seg.py 67.14% <67.14%> (ø)
mmdet3d/datasets/pipelines/transforms_3d.py 85.13% <84.21%> (+0.79%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d055876...cd1e015. Read the comment docs.

mmdet3d/core/bbox/transforms.py Show resolved Hide resolved
mmdet3d/datasets/__init__.py Outdated Show resolved Hide resolved
mmdet3d/core/bbox/box_np_ops.py Outdated Show resolved Hide resolved
mmdet3d/core/bbox/box_np_ops.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit ecd0d06 into open-mmlab:master Apr 7, 2021
@Tai-Wang Tai-Wang deleted the nus_mono3d branch July 6, 2021 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants