Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: fix compilation error in pytorch 1.7 #393

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

ZwwWayne
Copy link
Collaborator

In Pytorch 1.7, the cuda kernel of dynamic voxelization will cause compilation errors of error: class "at::Tensor" has no member "max_values" as mentioned in #362. This PR changes to use tensor.max() to fix the error.

Resolves #362

@ZwwWayne ZwwWayne requested a review from Tai-Wang March 29, 2021 13:38
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #393 (1795837) into master (dabf0a2) will not change coverage.
The diff coverage is n/a.

❗ Current head 1795837 differs from pull request most recent head e58419e. Consider uploading reports for the commit e58419e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   49.71%   49.71%           
=======================================
  Files         181      181           
  Lines       12451    12451           
  Branches     1951     1951           
=======================================
  Hits         6190     6190           
  Misses       5871     5871           
  Partials      390      390           
Flag Coverage Δ
unittests 49.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabf0a2...e58419e. Read the comment docs.

@ZwwWayne ZwwWayne merged commit b820b0b into open-mmlab:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I got Error when I install mmdetection3d on ubuntu 20.04 cuda 11.0 torch 1.7.0
2 participants