Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support multi-modality visualization (demos and dataset show function) #405

Merged
merged 16 commits into from
Apr 8, 2021

Conversation

Wuziyi616
Copy link
Contributor

Support visualizing 3D bounding boxes on the point cloud, while projecting the boxes onto 2D plane and drawing on the image. Both outdoor (lidar) and indoor (depth) point clouds are supported. The usage is similar to pcd_demo.py.

@Wuziyi616
Copy link
Contributor Author

Currently the user should input pre-computed camera matrix (pre-processed info file).

@Wuziyi616
Copy link
Contributor Author

Wuziyi616 commented Apr 2, 2021

Some demo examples (MVX-Net on KITTI and ImVoteNet on SUN RGB-D dataset).

kitti_000008_pred
sunrgbd_000017_pred

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #405 (9551792) into master (825f47a) will increase coverage by 0.27%.
The diff coverage is 62.80%.

❗ Current head 9551792 differs from pull request most recent head 9922c9d. Consider uploading reports for the commit 9922c9d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   50.17%   50.45%   +0.27%     
==========================================
  Files         184      184              
  Lines       13177    13320     +143     
  Branches     2097     2127      +30     
==========================================
+ Hits         6611     6720     +109     
- Misses       6130     6158      +28     
- Partials      436      442       +6     
Flag Coverage Δ
unittests 50.45% <62.80%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/lyft_dataset.py 65.26% <0.00%> (ø)
mmdet3d/datasets/nuscenes_dataset.py 33.48% <0.00%> (ø)
mmdet3d/apis/inference.py 56.00% <34.84%> (-23.69%) ⬇️
mmdet3d/core/visualizer/show_result.py 65.17% <57.14%> (-1.86%) ⬇️
mmdet3d/datasets/sunrgbd_dataset.py 75.60% <83.33%> (+3.00%) ⬆️
mmdet3d/core/visualizer/open3d_vis.py 27.94% <89.79%> (+27.94%) ⬆️
mmdet3d/apis/__init__.py 100.00% <100.00%> (ø)
mmdet3d/core/visualizer/__init__.py 100.00% <100.00%> (ø)
mmdet3d/datasets/kitti_dataset.py 76.22% <100.00%> (+0.45%) ⬆️
mmdet3d/datasets/scannet_dataset.py 95.16% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825f47a...9922c9d. Read the comment docs.

Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add related instructions into the documentation.

@Wuziyi616
Copy link
Contributor Author

Please also add related instructions into the documentation.

I have add information about multi-modality demo into getting_started.md and add a README file to demo.

docs/getting_started.md Outdated Show resolved Hide resolved
@Wuziyi616 Wuziyi616 changed the title [Feature] Support multi-modality visualization demos [Feature] Support multi-modality visualization (demos and dataset show function) Apr 4, 2021
@Wuziyi616
Copy link
Contributor Author

Apart from providing demos for multi-modality visualization, I also integrate it to the show function of dataset class (SUN RGB-D and KITTI dataset).

@Wuziyi616 Wuziyi616 requested a review from ZwwWayne April 6, 2021 03:27
demo/README.md Outdated Show resolved Hide resolved
docs/getting_started.md Show resolved Hide resolved
mmdet3d/core/visualizer/show_result.py Outdated Show resolved Hide resolved
mmdet3d/datasets/lyft_dataset.py Show resolved Hide resolved
docs/demo.md Outdated Show resolved Hide resolved
@Wuziyi616
Copy link
Contributor Author

Resolve conflicts with master branch.

@Wuziyi616 Wuziyi616 force-pushed the multi_modality_demo branch 2 times, most recently from 4dd2a22 to fa02722 Compare April 7, 2021 13:54
@ZwwWayne ZwwWayne merged commit e21e61e into open-mmlab:master Apr 8, 2021
@Wuziyi616 Wuziyi616 deleted the multi_modality_demo branch April 8, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants