[Feature] Support nuimages visualization #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
- Coverage 49.73% 49.67% -0.06%
==========================================
Files 181 181
Lines 12445 12464 +19
Branches 1950 1954 +4
==========================================
+ Hits 6189 6191 +2
- Misses 5867 5884 +17
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ZwwWayne
reviewed
Apr 6, 2021
Tai-Wang
reviewed
Apr 7, 2021
Tai-Wang
requested changes
Apr 7, 2021
ZwwWayne
reviewed
Apr 7, 2021
| model.module.show_results(data, result, out_dir) | ||
| # Visualize the results of MMdetection3D model | ||
| # 'show_results' is MMdetection3D visualization API | ||
| if hasattr(model.module, 'show_results'): |
There was a problem hiding this comment.
Should use isinstance to determine whether the detector is a 2D detector or a 3D detector.
ZwwWayne
approved these changes
Apr 7, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support nuimages visualization