Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] dynamic_scatter 'invalid configuration argument error' triggered by empty point input #417

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

zhanggefan
Copy link
Contributor

  • fix 'invalid configuration argument' error triggered by empty point input. test cases covering similar situations are added to test_dynamic_scatter.py as well.
    trivial changes:
  • switch to using torch::unique_dim to generate reduce mapping instead of calculating it from scratch.

- fix 'invalid configuration argument' error triggered by empty point input. test cases covering similar situations are added to test_dynamic_scatter.py as well.
trivial changes:
- switch to using torch::unique_dim to generate reduce mapping instead of calculating it from scratch.
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #417 (e21779c) into master (9cb75e7) will not change coverage.
The diff coverage is n/a.

❗ Current head e21779c differs from pull request most recent head 7f3187e. Consider uploading reports for the commit 7f3187e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   50.70%   50.70%           
=======================================
  Files         182      182           
  Lines       12765    12765           
  Branches     2014     2014           
=======================================
  Hits         6473     6473           
  Misses       5875     5875           
  Partials      417      417           
Flag Coverage Δ
unittests 50.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb75e7...7f3187e. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 3a5a201 into open-mmlab:master Apr 7, 2021
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants