Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix point type errors in docstring in pipeline functions #422

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

Wuziyi616
Copy link
Contributor

Fix issue#411, so that developers will understand the points during loading pipeline are instances of BasePoints class. They need to take out the tensor/coord/attribute of points in case some operations are not supported by BasePoints class.

@Wuziyi616 Wuziyi616 requested a review from ZwwWayne April 7, 2021 14:33
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #422 (10471f8) into master (ecd0d06) will not change coverage.
The diff coverage is n/a.

❗ Current head 10471f8 differs from pull request most recent head e7e7c50. Consider uploading reports for the commit e7e7c50 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   50.25%   50.25%           
=======================================
  Files         183      183           
  Lines       13142    13142           
  Branches     2090     2090           
=======================================
  Hits         6605     6605           
  Misses       6103     6103           
  Partials      434      434           
Flag Coverage Δ
unittests 50.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/pipelines/loading.py 83.82% <ø> (ø)
mmdet3d/datasets/pipelines/transforms_3d.py 85.13% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd0d06...e7e7c50. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 3116518 into open-mmlab:master Apr 8, 2021
@Wuziyi616 Wuziyi616 deleted the pipeline_comment_typos branch April 8, 2021 09:03
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* add rotated nms trt plugin

* fix ops output shape

* rebase

* fix lint

* add fp16, benchmark

* format docs

* remove unused definition, add ut

* add docs

* update docs

* add doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in docstrings of pre-processing functions
3 participants