Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fix the bug of missing points #423

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

gillbam
Copy link
Contributor

@gillbam gillbam commented Apr 7, 2021

Fix issue #406 :

  • "break" leads to points missing during voxelization;
  • "continue" ensures the completeness of voxelization

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2021

CLA assistant check
All committers have signed the CLA.

@gillbam gillbam changed the title [#406] fix the bug of missing points [FIX] fix the bug of missing points Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #423 (10297c7) into master (ecd0d06) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 10297c7 differs from pull request most recent head 9714872. Consider uploading reports for the commit 9714872 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   50.25%   50.25%           
=======================================
  Files         183      183           
  Lines       13142    13142           
  Branches     2090     2090           
=======================================
  Hits         6605     6605           
  Misses       6103     6103           
  Partials      434      434           
Flag Coverage Δ
unittests 50.25% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/voxel/voxel_generator.py 39.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd0d06...9714872. Read the comment docs.

@ZwwWayne ZwwWayne requested a review from hjin2902 April 8, 2021 08:54
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Apr 8, 2021

Hi @gillbam ,
Thanks for your kind contribution. Is the performance of models have been verified?

@hjin2902
Copy link
Contributor

SECOND kitti 3 classes mAP:

  • master: 66.59 (35 epoch, total 40 epoch)
  • continue-pr: 66.39 (35 epoch, total 40 epoch)

SECOND kitti car AP:

  • master: 78.32 (40 epoch)
  • continue-pr: 78.15 (40 epoch)

@ZwwWayne ZwwWayne merged commit 8d4bef2 into open-mmlab:master Apr 14, 2021
This was referenced Apr 24, 2021
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* support formatting `PixelFormat` & `DataType`

* format enum for legacy spdlog

* fix format
@OpenMMLab-Assistant-007
Copy link

Hi!
@gillbam
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants