-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Add pipeline for data loading #430
[Enhance] Add pipeline for data loading #430
Conversation
The added Also support semseg mask loading in scannet-seg dataset now. I have carefully checked all the configs and add eval_pipeline to configs with custom data pipelines. |
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
=========================================
Coverage ? 50.80%
=========================================
Files ? 184
Lines ? 13425
Branches ? 2160
=========================================
Hits ? 6820
Misses ? 6149
Partials ? 456
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Actually the commit message shouldn't be "reuse", because I pass into a new pipeline. "Reuse" is for easy understanding since the added eval_pipeline is similar to test_pipeline. |
Move the tedious if/else conditions to dataset._extract_data(). Set default value to pipeline. |
I have tried using |
Basic logic now:
|
configs/centerpoint/centerpoint_0075voxel_second_secfpn_4x8_cyclic_20e_nus.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have carefully checked all the config files and 5 of them needed not to be modified.
PRs can be merged after resolving conflicts. |
54158d1
to
27f05ad
Compare
Fix issue#412.
In dataset.show/evaluate() functions, we may need to load points/gt. In current implementations, we load them from disk using
np.fromfile()
, which is incompatible when data is in ceph. To solve this, we addeval_pipeline
in configs, and pass it as an argument to these functions. This pipeline purely consists of raw data loading operations (e.g. LoadImage, LoadPoints), eliminating the effects of data augmentation, and can adjust with the file client.