Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhance] Pipeline function process points and masks simultaneously #444

Merged
merged 4 commits into from
Apr 19, 2021
Merged

[Enhance] Pipeline function process points and masks simultaneously #444

merged 4 commits into from
Apr 19, 2021

Conversation

Wuziyi616
Copy link
Contributor

Fix issue#440. When filtering/sampling points in pipeline, perform the same actions on masks too.

@Wuziyi616
Copy link
Contributor Author

Maybe one potential question about ObjectSample in transforms_3d.py. If I understand correctly, this function sub-samples GTs so that we can train on a sub-class of original all classes. As it performs sampling, we also need to consider seg_mask here (currently these is only gt_bbox processing in this function). However, when I look into dbsampler and it seems impossible to fix this issue in a few lines of code. I tend to leave this function into future PRs.

@ZwwWayne ZwwWayne merged commit d4d7af2 into open-mmlab:master Apr 19, 2021
@Wuziyi616 Wuziyi616 deleted the pipeline_points_with_masks branch April 19, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tai-Wang Tai-Wang Tai-Wang approved these changes

@ZwwWayne ZwwWayne ZwwWayne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline functions may not process points and masks simultaneously
3 participants
@Wuziyi616 @Tai-Wang @ZwwWayne