Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #448 Clamp 3D votes projections to image boundaries #463

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

Divadi
Copy link
Contributor

@Divadi Divadi commented Apr 19, 2021

Fix issue #448:

  • Projection of 3D seed points to image sometimes results in out-of-range image indices (by 1 or 2 pixels)
  • Clamp the image indices to be within bounds

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2021

CLA assistant check
All committers have signed the CLA.

@yezhen17 yezhen17 self-assigned this Apr 19, 2021
@yezhen17
Copy link
Collaborator

image

It seems that you haven't followed this and installed the pre-commit hooks. Please take a took or simply break the long line into two, thank you!

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@b035bc8). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #463   +/-   ##
=========================================
  Coverage          ?   51.05%           
=========================================
  Files             ?      187           
  Lines             ?    13799           
  Branches          ?     2238           
=========================================
  Hits              ?     7045           
  Misses            ?     6277           
  Partials          ?      477           
Flag Coverage Δ
unittests 51.05% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/fusion_layers/vote_fusion.py 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b035bc8...9fa0cc0. Read the comment docs.

@ZwwWayne ZwwWayne merged commit a588943 into open-mmlab:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants