Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Add ScanNet alignment BC-breaking to compatibility document #470

Merged
merged 4 commits into from
May 11, 2021

Conversation

Wuziyi616
Copy link
Contributor

I imitate the compatibility document in MMDet and write a (very initial and very naive) version. Only includes the change on ScanNet dataset.

@Wuziyi616
Copy link
Contributor Author

Maybe we should add more terms to it, e.g. the model weight conversion for VoteNet on ScanNet?

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #470 (66e0c6d) into master (f5a5103) will not change coverage.
The diff coverage is n/a.

❗ Current head 66e0c6d differs from pull request most recent head 7278965. Consider uploading reports for the commit 7278965 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   50.59%   50.59%           
=======================================
  Files         192      192           
  Lines       14534    14534           
  Branches     2373     2373           
=======================================
  Hits         7353     7353           
  Misses       6687     6687           
  Partials      494      494           
Flag Coverage Δ
unittests 50.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a5103...7278965. Read the comment docs.

docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
@Wuziyi616 Wuziyi616 changed the title [Enhance] Add compatibility document [Enhance] Add ScanNet alignment BC-breaking to compatibility document Apr 28, 2021
yezhen17 added a commit to yezhen17/mmdetection3d that referenced this pull request Apr 29, 2021
ZwwWayne pushed a commit that referenced this pull request May 10, 2021
* Add compatibility doc based on #470

* Update zh-CN readme

* add VoteNet ckpt conversion and fix relative path

* fix another relative path under docs folder

* fix typo

* beautify docs and change order in compat doc
@Wuziyi616
Copy link
Contributor Author

Wuziyi616 commented May 10, 2021

One question: should we upload new pre-trained weights for models trained on newly processed ScanNet?

docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit 43d7953 into open-mmlab:master May 11, 2021
@Wuziyi616 Wuziyi616 deleted the compatibility branch May 11, 2021 13:46
@Wuziyi616 Wuziyi616 restored the compatibility branch May 11, 2021 13:47
@Wuziyi616 Wuziyi616 deleted the compatibility branch May 11, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ScanNet alignment BC-breaking to compatibility document of MMDet3D
3 participants