Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move project2image-type visualization functions to a new file #480

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

yezhen17
Copy link
Collaborator

No description provided.

@yezhen17 yezhen17 requested a review from ZwwWayne April 24, 2021 07:09
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #480 (624ce3f) into master (f7356f4) will decrease coverage by 0.09%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   50.62%   50.52%   -0.10%     
==========================================
  Files         191      192       +1     
  Lines       14450    14454       +4     
  Branches     2367     2367              
==========================================
- Hits         7315     7303      -12     
- Misses       6643     6659      +16     
  Partials      492      492              
Flag Coverage Δ
unittests 50.52% <60.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/visualizer/open3d_vis.py 0.00% <ø> (-27.95%) ⬇️
mmdet3d/core/visualizer/image_vis.py 58.62% <58.62%> (ø)
mmdet3d/core/visualizer/show_result.py 65.48% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7356f4...624ce3f. Read the comment docs.

Copy link
Contributor

@Wuziyi616 Wuziyi616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree to split them into two files.

@ZwwWayne ZwwWayne merged commit eead419 into open-mmlab:master Apr 28, 2021
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* fix mmseg twich resize

* remove comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants